Repository navigation
combined-json: fix a confusion with colons in the source path - #674
Merged
Merged
Conversation
Signed-off-by: xermicus <cyrill@parity.io>
elle-j
approved these changes
Oct 7, 2026
elle-j
reviewed
Oct 7, 2026
| } | ||
|
|
||
| /// Executes the `resolc` command with the given `arguments` inside the working `directory`. | ||
| pub fn execute_resolc_in_directory(arguments: &[&str], directory: &Path) -> CommandResult { |
Contributor
There was a problem hiding this comment.
To resolve a future conflict with PR 678 now, could you update this file's pub fn execute_resolc_in_directory() with 678's crates/resolc/src/cli_utils.rs code? 678's structure is a bit cleaner I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #661