Skip to content

Removing a user from an identity-provider group never revokes the OIDC role #1864

Open

Description

@stalingino

/about output: version v3.2.7 (also on main at 0de90cf).

Description:

For a returning OIDC user, resolve_roles (src/handlers/http/oidc.rs) adds the roles matching the user's groups claim to the roles they already have (roles.extend(valid_oidc_roles)). Nothing is ever removed. This deliberately preserves roles an admin assigned inside Parseable (#1356). The consequence is that removing a user from a group in the identity provider never revokes the corresponding Parseable role.

When the identity provider (LDAP/FreeIPA via Dex, Keycloak, Entra ID, ...) is meant to be the single source of truth for access, that is a security gap: offboarding someone from a group leaves their dataset access in place until an admin edits the user by hand.

Expected: an opt-in setting (e.g. P_OIDC_SYNC_ROLES=true) under which, at every login, an OIDC user's roles are set to exactly the roles their groups name, falling back to the default role as today. The default stays as it is, so #1356's behaviour is unchanged unless the setting is on.

Activity

  1. nikhilsinhaparseable commented on Nov 19, 2026

    @nikhilsinhaparseable
    Member

    @stalingino thanks for reporting the issue, we will take a look and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions