Repository navigation
Conversation
`backHref: null` shows no back arrow, for an embedded viewer with nowhere to go back to. Existing callers keep theirs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR makes the back arrow in
Start with the render branch around line 111: the new |
AxiomeCG
marked this pull request as draft
October 6, 2026 16:38
AxiomeCG
marked this pull request as ready for review
October 6, 2026 17:54
…irs, pascalorg#996 hosted service contracts) into the embed mode Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ViewerSceneHeadercan show no back arrow:backHref: nullhides it. An embedded viewer (/viewer/<id>?embed=1in pascalorg/private-editor#838, which renders the editor's Preview in a listing's iframe) has nowhere to go back to unless the embedding page gives areturnTo. Existing callers pass a string or nothing, so their arrow is unchanged.How to test
onBack), and the public viewer's header still links back (backHref)./viewer/demo_1?embed=1shows the header with no back arrow, and/viewer/demo_1?embed=1&returnTo=/communityshows one linking to/community(itsviewer-embed.spec.tscovers both).Screenshots / screen recording
N/A: the visible change is in #838's embed.
Checklist
bun devbun checkto verify)mainbranch🤖 Generated with Claude Code
Note
Low Risk
Small conditional UI in the viewer header with no auth or data changes; default back link behavior is preserved.
Overview
ViewerSceneHeadernow treatsbackHref: nullas “no back control”: when there is noonBackhandler, the header skips the backLinkinstead of defaulting to/.The prop type is
string | nulland the docs call out embedded viewers (e.g. iframe) that may have no sensible return URL unless the parent passes one.Existing behavior is unchanged for callers that omit
backHref(still/) or pass a string;onBackstill wins overbackHref.Reviewed by Cursor Bugbot for commit a18817c. Bugbot is set up for automated code reviews on this repo. Configure here.