Repository navigation
Site: lot as a block in mapped surroundings, straight front setbacks - #1017
Steven-Tibbs wants to merge 1 commit into
Conversation
…backs - Terrain: with a property line, the lot's ground is cut to the line and closed by a skirt down to one flat base (the lot reads as a block inside mapped 3D surroundings); the horizon disc sits just under that base. - Viewer: claimSceneGround(scene) lets a map layer outside React claim the scene ground (the fallback disc steps aside until released). - Camera: max distance 1500 m while the ground is replaced (a neighbourhood instead of the horizon disc), 100 m otherwise. - Site plan: an edge running nearly straight on (within 8°) from a front or street edge takes that edge's setback, so a frontage split into two collinear pieces no longer gets a curved setback arc. - Lot drop-in: no second roads lookup after a slow miss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Engine side of the Architect's lot work, in three parts. With a property line on the site, the terrain now renders as a block: the ground surface is masked to the parcel per fragment, and a skirt follows the property line down to one flat base, so the lot reads as a solid sitting inside mapped 3D surroundings instead of a disc that caps it. The viewer gets a
Start with |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 27811f6. Configure here.
| const distances: number[] = [] | ||
| for (let i = 0; i < n; i++) { | ||
| const role = runRole.get(runs[i] as number) ?? (roles[i] as EdgeRole) | ||
| const role = continued.get(i) ?? runRole.get(runs[i] as number) ?? (roles[i] as EdgeRole) |
There was a problem hiding this comment.
3D setbacks miss straight frontage
Medium Severity
The new nearly-straight frontage inheritance lives only in the editor setbackEnvelope. The nodes copy, which the 3D dashed overlay uses and which is documented as the same rules, still treats the leftover half as a side yard, so a split frontage still draws a curved envelope in the scene.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 27811f6. Configure here.
| addSlabHoles(shape, slabPolygons, fadeBounds.cx, fadeBounds.cz) | ||
| return new ShapeGeometry(shape) | ||
| }, [fadeBounds, slabPolygons, terrainKey, groundReplaced]) | ||
| }, [fadeBounds, slabPolygons, groundReplaced]) |
There was a problem hiding this comment.
Horizon disc caps live excavation
Medium Severity
The horizon disc no longer punches terrainFootprint and instead sits at a React horizonY from terrainBlockBase. A sculpt stroke rewrites the mesh and skirt in place but does not move that disc, so a pit that drops below the last committed base is roofed over until the stroke commits.
Reviewed by Cursor Bugbot for commit 27811f6. Configure here.
This branch has not been deployed
1 participant
Engine side of the Architect's lot and map work. App PR: https://github.com/pascalorg/private-editor/pull/857 — merge this one first. @Aymericr
lot-mask.ts).claimSceneGround(scene)lets a map layer outside React take over the scene ground.Tests: terrain-geometry 45 pass, site-plan + lot 66 pass. tsc clean (viewer, nodes, editor).
🤖 Generated with Claude Code