Repository navigation
Pascal Editor: Simplified Chinese localization (zh-CN) #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ import { | |
| MODULAR_CABINET_ICON, | ||
| } from '@/lib/build-palette' | ||
| import { getActiveRoofFeatureId, ROOF_TYPE_OPTIONS } from '@/lib/build-tab-state' | ||
| import { useI18n } from '@/lib/i18n' | ||
| import { cn } from '@/lib/utils' | ||
|
|
||
| const subscribeToClientMount = () => () => {} | ||
|
|
@@ -60,6 +61,7 @@ const subscribeToClientMount = () => () => {} | |
| * with the kind's own `def.defaults()`. Painting has its own rail panel. | ||
| */ | ||
| export function BuildTab() { | ||
| const { translateDisplayText } = useI18n() | ||
| const [mepOpen, setMepOpen] = useState(false) | ||
| const activeTool = useEditor((s) => s.tool) | ||
| const selectedId = useViewer((s) => s.selection.selectedIds[0]) | ||
|
|
@@ -178,13 +180,13 @@ export function BuildTab() { | |
| data-build-tool={type.id} | ||
| iconSrc={type.iconSrc} | ||
| key={type.id} | ||
| label={type.label} | ||
| label={translateDisplayText(type.label)} | ||
| onClick={() => { | ||
| triggerSFX('sfx:menu-click') | ||
| handleTypeClick(type) | ||
| }} | ||
| onMouseEnter={() => triggerSFX('sfx:menu-hover')} | ||
| title={type.label} | ||
| title={translateDisplayText(type.label)} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Roof UI ignores prepared translation keysMedium Severity
Additional Locations (1)Reviewed by Cursor Bugbot for commit 23b1703. Configure here. |
||
| /> | ||
| ) | ||
| const typesIn = (section: NonNullable<BuildType['section']>) => | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidebar tabs use the wrong catalog
Medium Severity
Home sidebar labels go through
translateDisplayTextinstead of the typedsidebar.*keys.SceneandSettingshave no display-map entries and stay English, whileBuildresolves to建筑rather than建模.Additional Locations (2)
apps/editor/lib/i18n.tsx#L8-L12apps/editor/lib/i18n.tsx#L712-L713Reviewed by Cursor Bugbot for commit 23b1703. Configure here.