-
Notifications
You must be signed in to change notification settings - Fork 105
feat(alert): add pf-alert #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brianferry
wants to merge
15
commits into
main
Choose a base branch
from
feat/add-pf-alert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
33afe49
feat: init commit with pf-alert
brianferry df55c1d
feat: truncated title and timeout
brianferry 6185d07
feat(alert): adding plain, custom icons
brianferry 20eaf92
Merge branch 'main' of github.com:patternfly/patternfly-elements into…
brianferry 544a0c6
feat(alert): cleaning up css, fallback variables for important styles…
brianferry c68683a
feat(core): adding isEmpty, hasSlotted w/ default slot
brianferry da3c824
chore: adding changeset
brianferry 4a1dacf
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry 9a03851
Update core/pfe-core/controllers/slot-controller.ts
brianferry 147b672
chore: merging with feat/default-slot
brianferry e1cfe19
fix(core): adding anonymous slot back to SlotController
brianferry 88e079d
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry 8e2cd9e
feat(alert): multiple demos, jsdocs, adding pf-icon
brianferry d97a4f7
fix(alert): private css variables, moving ICONS call inline, removing…
brianferry 472fa59
docs(alert): inline scripts, heading tags fixing
brianferry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennypowers marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Alert | ||
| Add a description of the component here. | ||
|
|
||
| ## Usage | ||
| Describe how best to use this web component along with best practices. | ||
|
|
||
| ```html | ||
| <pf-alert> | ||
|
|
||
| </pf-alert> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| pf-alert { | ||
| padding: 0.5rem; | ||
| display: block; | ||
| } | ||
|
|
||
| pf-button { | ||
| display: block; | ||
| padding-block: 1em; | ||
| } | ||
|
|
||
| #timeout-alerts { | ||
| min-height: 200px; | ||
| border: 1px solid #000; | ||
| margin: 0.5rem; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| <link rel="stylesheet" href="demo.css"> | ||
| <script type="module" src="pf-alert.js"></script> | ||
|
|
||
| <pf-alert title="Default alert title"></pf-alert> | ||
brianferry marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| <pf-alert variant="info" title="Info alert title"></pf-alert> | ||
| <pf-alert variant="success" title="Success alert title"></pf-alert> | ||
| <pf-alert variant="warning" title="Warning alert title"></pf-alert> | ||
| <pf-alert variant="danger" title="Danger alert title"></pf-alert> | ||
|
|
||
| <h1> | ||
| Alert Variations | ||
| </h1> | ||
|
|
||
| <pf-alert title="Success alert title" variant="success" dismissable> | ||
| <p>Success alert description. This should tell the user more information about the alert.</p> | ||
| <button slot="actions">View details</button> | ||
| <button slot="actions">Ignore</button> | ||
| </pf-alert> | ||
|
|
||
| <pf-alert title="Success alert title" variant="success" dismissable> | ||
| <p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
| <p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
| </pf-alert> | ||
|
|
||
| <pf-alert title="Success alert title" variant="success" dismissable> | ||
| <button slot="actions">View details</button> | ||
| <button slot="actions">Ignore</button> | ||
| </pf-alert> | ||
|
|
||
| <pf-alert title="Success alert title" variant="success" dismissable> | ||
|
|
||
| <p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
| <p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
| <button slot="actions">View details</button> | ||
| <button slot="actions">Ignore</button> | ||
| <button slot="actions">Ignore</button> | ||
| <button slot="actions">Ignore</button> | ||
| <button slot="actions">Ignore</button> | ||
| <button slot="actions">Ignore</button> | ||
| </pf-alert> | ||
|
|
||
| <pf-alert title="Success alert title" variant="success" dismissable></pf-alert> | ||
|
|
||
| <h1> | ||
| Default Icons | ||
| </h1> | ||
|
|
||
| <pf-alert title="Custom icon"> | ||
| <pf-icon slot="icon" set="fas" icon="users" loading="idle"></pf-icon> | ||
| </pf-alert> | ||
| <pf-alert title="Custom info icon" variant="info"> | ||
| <pf-icon slot="icon" set="fas" icon="box" loading="idle"></pf-icon> | ||
| </pf-alert> | ||
| <pf-alert title="Custom success icon" variant="success"> | ||
| <pf-icon slot="icon" set="fas" icon="database" loading="idle"></pf-icon> | ||
| </pf-alert> | ||
| <pf-alert title="Custom warning icon" variant="warning"> | ||
| <pf-icon slot="icon" set="fas" icon="server" loading="idle"></pf-icon> | ||
| </pf-alert> | ||
| <pf-alert title="Custom danger icon" variant="danger"> | ||
| <pf-icon slot="icon" set="fas" icon="laptop" loading="idle"></pf-icon> | ||
| </pf-alert> | ||
|
|
||
| <h1> | ||
| Plain | ||
| </h1> | ||
|
|
||
| <pf-alert title="Default plain" plain></pf-alert> | ||
| <pf-alert variant="info" title="Info plain" plain></pf-alert> | ||
| <pf-alert variant="success" title="Success plain" plain dismissable> | ||
| <p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
| <button slot="actions">Ignore</button> | ||
| </pf-alert> | ||
| <pf-alert variant="warning" title="Warning plain" plain></pf-alert> | ||
| <pf-alert variant="danger" title="Danger plain" plain></pf-alert> | ||
|
|
||
| <h1> | ||
| Inline | ||
| </h1> | ||
|
|
||
| <pf-alert title="Default inline" inline></pf-alert> | ||
| <pf-alert variant="info" title="Info inline" inline></pf-alert> | ||
| <pf-alert variant="success" title="Success inline" inline></pf-alert> | ||
| <pf-alert variant="warning" title="Warning inline" inline></pf-alert> | ||
| <pf-alert variant="danger" title="Danger inline" inline></pf-alert> | ||
|
|
||
| <h1> | ||
| Plain | ||
| </h1> | ||
|
|
||
| <pf-alert title="Default inline" plain></pf-alert> | ||
| <pf-alert variant="info" title="Info inline" plain></pf-alert> | ||
| <pf-alert variant="success" title="Success inline" plain></pf-alert> | ||
| <pf-alert variant="warning" title="Warning inline" plain></pf-alert> | ||
| <pf-alert variant="danger" title="Danger inline" plain></pf-alert> | ||
|
|
||
| <h1> | ||
| Inline Plain | ||
| </h1> | ||
|
|
||
| <pf-alert title="Default inline" inline plain></pf-alert> | ||
| <pf-alert variant="info" title="Info inline" inline plain></pf-alert> | ||
| <pf-alert variant="success" title="Success inline" inline plain></pf-alert> | ||
| <pf-alert variant="warning" title="Warning inline" inline plain></pf-alert> | ||
| <pf-alert variant="danger" title="Danger inline" inline plain></pf-alert> | ||
|
|
||
| <h1> | ||
| Truncated Title | ||
| </h1> | ||
|
|
||
| <pf-alert style="width:100px;" truncate-title title="It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief, it was the epoch of incredulity, it was the season of light, it was the season of darkness, it was the spring of hope, it was the winter of despair."></pf-alert> | ||
|
|
||
| <h1> | ||
| Timeout | ||
| </h1> | ||
|
|
||
| <pf-button id="create-timeout-alert">Create default timeout alert</pf-button> | ||
| <pf-button id="create-timeout-inline-alert">Create inline timeout alert</pf-button> | ||
|
|
||
| <input type="range" id="timeout-range" min="0" max="10000" step="100" value="1000" /> | ||
| <label for="timeout-range">Timeout: <span id="timeout-value">1000</span>ms</label> | ||
| <pf-button id="create-Default-timeout-alert">Create Default timeout alert</pf-button> | ||
|
|
||
| <section id="timeout-alerts"></section> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import '@patternfly/elements/pf-alert/pf-alert.js'; | ||
| import '@patternfly/elements/pf-button/pf-button.js'; | ||
| import '@patternfly/elements/pf-icon/pf-icon.js'; | ||
|
|
||
| const createTimeoutAlert = document.getElementById('create-timeout-alert'); | ||
| const createInlintTimeoutAlert = document.getElementById('create-timeout-inline-alert'); | ||
| const timeoutRange = document.getElementById('timeout-range'); | ||
| const timeoutValue = document.getElementById('timeout-value'); | ||
| const createCustomTimeoutAlert = document.getElementById('create-custom-timeout-alert'); | ||
| const timeoutAlertsSection = document.getElementById('timeout-alerts'); | ||
|
|
||
| createTimeoutAlert.addEventListener('click', () => { | ||
| const pfeAlert = document.createElement('pf-alert'); | ||
| pfeAlert.title = 'Default Timeout Alert 8000ms'; | ||
| pfeAlert.timeout = true; | ||
| timeoutAlertsSection.appendChild(pfeAlert); | ||
| }); | ||
|
|
||
| createInlintTimeoutAlert.addEventListener('click', () => { | ||
| const pfeAlert = document.createElement('pf-alert'); | ||
| pfeAlert.title = 'Inline Timeout Alert 8000ms'; | ||
| pfeAlert.timeout = true; | ||
| timeoutAlertsSection.appendChild(pfeAlert); | ||
| }); | ||
|
|
||
| createCustomTimeoutAlert.addEventListener('click', () => { | ||
| const pfeAlert = document.createElement('pf-alert'); | ||
| pfeAlert.title = `Custom Timeout Alert ${timeoutRange.value}ms`; | ||
| pfeAlert.timeout = timeoutRange.value; | ||
| timeoutAlertsSection.appendChild(pfeAlert); | ||
| }); | ||
|
|
||
| timeoutRange.addEventListener('change', () => { | ||
| timeoutValue.innerText = timeoutRange.value; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| {% renderOverview %} | ||
| <pf-alert></pf-alert> | ||
| {% endrenderOverview %} | ||
|
|
||
| {% band header="Usage" %}{% endband %} | ||
|
|
||
| {% renderSlots %}{% endrenderSlots %} | ||
|
|
||
| {% renderAttributes %}{% endrenderAttributes %} | ||
|
|
||
| {% renderMethods %}{% endrenderMethods %} | ||
|
|
||
| {% renderEvents %}{% endrenderEvents %} | ||
|
|
||
| {% renderCssCustomProperties %}{% endrenderCssCustomProperties %} | ||
|
|
||
| {% renderCssParts %}{% endrenderCssParts %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.