Skip to content

fix(core): prevent race condition on programmatic scroll #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): prevent race condition on programmatic scroll #2911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/pfe-core/controllers/scroll-spy-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ export class ScrollSpyController implements ReactiveController {
/** Has the intersection observer found an element? */
#intersected = false;

#destinationTarget: Element | null = null;

#root: ScrollSpyControllerOptions['root'];

#rootMargin?: string;
Expand Down Expand Up @@ -201,6 +203,12 @@ export class ScrollSpyController implements ReactiveController {
}

async #onIo(entries: IntersectionObserverEntry[]) {
if (this.#force && this.#destinationTarget) {
if (entries.some(e => e.target === this.#destinationTarget && e.isIntersecting)) {
this.#force = false;
this.#destinationTarget = null;
}
}
if (!this.#force) {
for (const { target, boundingClientRect, intersectionRect } of entries) {
const selector = `:is(${this.#tagNames.join(',')})[href="#${target.id}"]`;
Expand Down Expand Up @@ -244,14 +252,13 @@ export class ScrollSpyController implements ReactiveController {
public async setActive(link: EventTarget | null): Promise<void> {
this.#force = true;
this.#setActive(link);
this.#destinationTarget = this.#linkTargetMap.get(link as Element) ?? null;
let sawActive = false;
for (const child of this.#linkChildren) {
this.#markPassed(child, !sawActive);
if (child === link) {
sawActive = true;
}
}
await this.#nextIntersection();
this.#force = false;
}
}
Loading