Skip to content

Conversation

@katarinazaprazna
Copy link

@katarinazaprazna katarinazaprazna commented Oct 28, 2025

Expose additional menuToggleProps in the component's API. This is necessary for the Content Services use case, as we need to programmatically disable the split button toggle.

@patternfly-build
Copy link

patternfly-build commented Oct 28, 2025

@nicolethoen
Copy link
Contributor

I have no objection to exposing the MenuToggleProps.

I'd rather not use that to replace the DropdownListProps, since that'd be a breaking change for anyone who may have possibly been using DropdowListProps. Could you make this an additive change and make sure both exposed props objects are being spread through correctly? rather than the replacement it currently is?

@nicolethoen nicolethoen self-requested a review November 7, 2025 13:32
@katarinazaprazna
Copy link
Author

That's a great point @nicolethoen, thanks for catching that. I hadn't considered it, especially since the props were requested by my team. I'll look into it :)

@katarinazaprazna katarinazaprazna force-pushed the fix-bulkselect-exposing-additional-props branch from 0788ed2 to dcd784a Compare November 9, 2025 19:18
@katarinazaprazna katarinazaprazna changed the title fix(BulkSelect): expose correct additional props feat(BulkSelect): expose menuToggleProps props Nov 9, 2025
@katarinazaprazna katarinazaprazna changed the title feat(BulkSelect): expose menuToggleProps props feat(BulkSelect): expose menuToggle props Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants