Skip to content

fix: Updates navigation placement for redesign. #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
+16,163 −94
Merged

fix: Updates navigation placement for redesign. #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee3e1e2
docs: Updates navigation placement for redesign.
edonehoo Nov 11, 2025
dbe0486
fix failing cypress test
nicolethoen Nov 14, 2025
7200043
fix failing cypress test
nicolethoen Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/CloseButton.spec.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
describe('Test the close button', () => {
it('passes', () => {
cy.visit('http://localhost:8006/component-groups/controls/close-button', { onBeforeLoad: (win) => {cy.stub(win.console, 'log').as('consoleLog');}, });
cy.visit('http://localhost:8006/extensions/component-groups/close-button', { onBeforeLoad: (win) => {cy.stub(win.console, 'log').as('consoleLog');}, });
cy.wait(1000);

cy.get('[data-test-id="close-button-example"]').click();
Expand Down
2,765 changes: 2,725 additions & 40 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 4 additions & 2 deletions ...e/patternfly-docs/content/extensions/component-groups/about-component-groups.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
---
section: Component groups
id: About component groups
section: Extensions
subsection: Component groups
id: Overview
title: Component groups overview
sortValue: 1
sourceLink: https://github.com/patternfly/react-component-groups/blob/main/packages/module/patternfly-docs/content/extensions/component-groups/about-component-groups.md
---
Expand Down
4 changes: 2 additions & 2 deletions ...patternfly-docs/content/extensions/component-groups/examples/Ansible/Ansible.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Ansible
Expand Down
4 changes: 2 additions & 2 deletions ...nfly-docs/content/extensions/component-groups/examples/BulkSelect/BulkSelect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Controls
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Bulk select
Expand Down
4 changes: 2 additions & 2 deletions ...ly-docs/content/extensions/component-groups/examples/CloseButton/CloseButton.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Controls
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Close button
Expand Down
4 changes: 2 additions & 2 deletions ...nsions/component-groups/examples/ColumnManagementModal/ColumnManagementModal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Helpers
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Column management modal
Expand Down
4 changes: 2 additions & 2 deletions ...ocs/content/extensions/component-groups/examples/ErrorBoundary/ErrorBoundary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Error boundary
Expand Down
4 changes: 2 additions & 2 deletions ...nfly-docs/content/extensions/component-groups/examples/ErrorState/ErrorState.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Error state
Expand Down
4 changes: 2 additions & 2 deletions ...t/extensions/component-groups/examples/ExternalLinkButton/ExternalLinkButton.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Controls
section: Extensions
subsection: Component groups
id: External link button
source: react
propComponents: ['ExternalLinkButton']
Expand Down
4 changes: 2 additions & 2 deletions ...-docs/content/extensions/component-groups/examples/FieldBuilder/FieldBuilder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Helpers
section: Extensions
subsection: Component groups
id: Field Builder
source: react
propComponents: ['FieldBuilder']
Expand Down
4 changes: 2 additions & 2 deletions ...ly-docs/content/extensions/component-groups/examples/ListManager/ListManager.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Helpers
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: List manager
Expand Down
4 changes: 2 additions & 2 deletions ...nfly-docs/content/extensions/component-groups/examples/LogSnippet/LogSnippet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Helpers
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Log snippet
Expand Down
4 changes: 2 additions & 2 deletions ...ly-docs/content/extensions/component-groups/examples/Maintenance/Maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Maintenance
Expand Down
4 changes: 2 additions & 2 deletions ...ly-docs/content/extensions/component-groups/examples/MissingPage/MissingPage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Missing page
Expand Down
4 changes: 2 additions & 2 deletions ...ntent/extensions/component-groups/examples/MultiContentCard/MultiContentCard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Content containers
section: Extensions
subsection: Component groups
id: Multi-content card
source: react
propComponents: ['MultiContentCard']
Expand Down
4 changes: 2 additions & 2 deletions ...nfly-docs/content/extensions/component-groups/examples/PageHeader/PageHeader.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Content containers
section: Extensions
subsection: Component groups
id: Page header
source: react
propComponents: ['PageHeader']
Expand Down
4 changes: 2 additions & 2 deletions ...ent/extensions/component-groups/examples/ResponsiveActions/ResponsiveActions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Controls
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Responsive actions
Expand Down
4 changes: 2 additions & 2 deletions ...ly-docs/content/extensions/component-groups/examples/ServiceCard/ServiceCard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Content containers
section: Extensions
subsection: Component groups
id: Service card
source: react
propComponents: ['ServiceCard']
Expand Down
4 changes: 2 additions & 2 deletions ...tternfly-docs/content/extensions/component-groups/examples/Severity/Severity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Severity
Expand Down
4 changes: 2 additions & 2 deletions ...-docs/content/extensions/component-groups/examples/ShortcutGrid/ShortcutGrid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Helpers
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Shortcut grid
Expand Down
4 changes: 2 additions & 2 deletions ...ocs/content/extensions/component-groups/examples/SkeletonTable/SkeletonTable.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Skeleton table
Expand Down
4 changes: 2 additions & 2 deletions ...ntent/extensions/component-groups/examples/StaleDataWarning/StaleDataWarning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Stale data warning
Expand Down
4 changes: 2 additions & 2 deletions ...e/patternfly-docs/content/extensions/component-groups/examples/Status/Status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Status
Expand Down
4 changes: 2 additions & 2 deletions ...tternfly-docs/content/extensions/component-groups/examples/TagCount/TagCount.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Status and state indicators
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Tag count
Expand Down
4 changes: 2 additions & 2 deletions ...t/extensions/component-groups/examples/UnauthorizedAccess/UnauthorizedAccess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
id: Unauthorized access
source: react
propComponents: ['UnauthorizedAccess']
Expand Down
4 changes: 2 additions & 2 deletions .../content/extensions/component-groups/examples/Unavailable/UnavailableContent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Unavailable content
Expand Down
4 changes: 2 additions & 2 deletions ...-docs/content/extensions/component-groups/examples/WarningModal/WarningModal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: Component groups
subsection: Error communication
section: Extensions
subsection: Component groups
# Sidenav secondary level section
# should be the same for all markdown files
id: Warning modal
Expand Down
2 changes: 1 addition & 1 deletion packages/module/patternfly-docs/patternfly-docs.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// This module is shared between NodeJS and babelled ES5
module.exports = {
sideNavItems: [ { section: 'Component groups' } ],
sideNavItems: [ { section: 'Extensions' } ],
topNavItems: [],
port: 8006
};
Loading
Loading