Fix all clippy warnings across the codebase#21
Draft
0xZaddyy wants to merge 22 commits intopayjoin:masterfrom
Draft
Fix all clippy warnings across the codebase#210xZaddyy wants to merge 22 commits intopayjoin:masterfrom
0xZaddyy wants to merge 22 commits intopayjoin:masterfrom
Conversation
Remove 2p payjoin support
Contributor
Author
|
I need to rebase to resolve the conflicts. |
Open
0xZaddyy
force-pushed
the
clippy-warnings
branch
from
242fd4f to
9a0d22b
Compare
Collaborator
|
As part of this PR, please add clippy checks to CI. Thanks |
Given an order book of UTXOs and a takers utxos which order book utxos we generate a list of cospends candidates.
To maker and taker
This action costs more if you have payment obligations. Or if you already have a input registered. In the future this can be smarter and internalize the cost of registering specific inputs with respect to the po's and privacy budget.
As its replaced by create cospend. And explicitly assign cost to accepting the co spend.
Return registered inputs from order book
Mark po's as success if they are handled in the a cospend.
This commit also folds all action outcomes into on Outcome struct which defines how the wallet state has changes. This allows us to reconcile cost terms to one metacost function and eval global wallet changes in one place.
As its replaced by create cospend methods
First run all unilateral actions available to a strategy, find what inputs are common in all plans, register than inputs.
Orderbook utxos are utxos that capture some metadata including: amount and owner.
Confirmed or broadcasted
Co-Authored-By: bc1cindy <bc1cindy@proton.me>
Address warnings from `cargo clippy --workspace --all-targets --all-features` : renamed deprecated `gen_range` to `random_range`, simplified iterator/borrow patterns, derived `Default` where possible, used `div_ceil`/`is_multiple_of`, switched HashMap access to `entry` API, dropped redundant closures and `clone()` on Copy types, and annotated intentionally unused API methods with `#[allow(dead_code)]`.
0xZaddyy
force-pushed
the
clippy-warnings
branch
from
9a0d22b to
54237bb
Compare
Address warnings from `cargo clippy --workspace --all-targets --all-features` : renamed deprecated `gen_range` to `random_range`, simplified iterator/borrow patterns, derived `Default` where possible, used `div_ceil`/`is_multiple_of`, switched HashMap access to `entry` API, dropped redundant closures and `clone()` on Copy types, and annotated intentionally unused API methods with `#[allow(dead_code)]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr resolves all
cargo clippy --workspace --all-targets --all-featureswarnings so the tree builds clean under clippy.closes #20