Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 23951733625Details
💛 - Coveralls |
benalleng
force-pushed
the
pin-icu
branch
2 times, most recently
from
fa97664 to
b771199
Compare
benalleng
changed the title
Closed
Collaborator
Author
|
Edit: We're so back |
benalleng
force-pushed
the
pin-icu
branch
2 times, most recently
from
2bce8f6 to
f80769a
Compare
spacebear21
reviewed
Apr 3, 2026
spacebear21
reviewed
Apr 3, 2026
Comment on lines
+20
to
+21
| cargo add icu_locale_core@=2.0.1 --package uniffi-bindgen-react-native | ||
| cargo add icu_provider@=2.0.0 --package uniffi-bindgen-react-native |
Collaborator
There was a problem hiding this comment.
was this actually required here? IIRC the "heinous hack" is for a transitive dependency of the ubrn package that can't be pinned otherwise. If icu is only being pulled from the payjoin test utils dep we shouldn't need that hack here.
Collaborator
Author
There was a problem hiding this comment.
possibly, I need to double check as actually figuring out the issue was a trip
spacebear21
approved these changes
Apr 3, 2026
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
utACK - thanks for picking this up! Agreed on the push for dropping url
The icu_provider and dependant crates all had msrv breaking updates that were not caught by our CI causing some upstream regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ended up that we can pin icu_provider back to fix a whole tree. All the more reason to try and push for #1124 i guess.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.