Fix mainnet indexing failure with multiple block files#46
Closed
0xZaddyy wants to merge 5 commits intopayjoin:masterfrom
Closed
Fix mainnet indexing failure with multiple block files#460xZaddyy wants to merge 5 commits intopayjoin:masterfrom
0xZaddyy wants to merge 5 commits intopayjoin:masterfrom
Conversation
The parser was previously hardcoded to only read from blk00000.dat, causing an EOF error when blocks spanned multiple files on mainnet
Replace all `if let ... && ...` patterns with nested if statements to maintain compatibility with stable Rust. This fixes compilation errors related to unstable let-chain expressions (E0658).
Contributor
Author
|
Removing all related clippy warning fixes here, as they are all addressed in #47 |
Collaborator
|
This may be a dup of #39 |
Contributor
Author
|
@arminsabouri do you suggest i close this? |
Collaborator
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurred because the parser was hardcoded to only read from blk00000.dat, but Bitcoin Core distributes blocks across multiple files (~128MB each). When trying to index blocks that exist in later files (e.g., blk00001.dat, blk00002.dat), the parser would attempt to read beyond the first file's boundaries, causing an EOF error.
closes #44