Open
Conversation
Cloned another folder and set it up for Italy
Member
|
Ciao @massimogentilini, Thanks for this! Looks good overall. I don't think exposing port |
Author
|
Correct, I’ll remove it.
… Il giorno 11 mar 2021, alle ore 20:04, Julian Simioni ***@***.***> ha scritto:
Ciao @massimogentilini,
Thanks for this!
Looks good overall. I don't think exposing port 5601 on the Elasticsearch container does anything though, right? That's usually the port for Kibana but our Elasticsearch docker image does not include Kibana.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
Hi, sorry I merged #287 first, are you happy with that or can we take some of the config in this PR and merge them to create something better? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloned another folder and set it up for Italy
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
Here's what actually got changed 👏
Here's how others can test the changes 👀