Conversation
Member
|
I forgot to reply to this earlier, but it's very nice. Maybe we wait until after #386 is merged so that this diff is much smaller and simpler? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.
Here's the reason for this change 🚀
As discussed in #373 here is updated version with https://github.com/geocodeearth/autocomplete-element instead of nextzen-leaflet. Due to laziness the url (localhost:4000) is hardcoded in the bundle.js. We could link the api in the docker-compose.yml which would allow us to use the container name instead of ip but wont solve the problem with the port. But since this is only nice2have I don't see it as this big of a problem.
Here's what actually got changed 👏
Here's how others can test the changes 👀
Fire up any project with existing data, go to "localhost:3000" and search something.
Closes #373