Improved classification of subdivision/unit#180
Conversation
| @@ -217,23 +217,23 @@ const testcase = (test, common) => { | |||
| ]], false) | |||
There was a problem hiding this comment.
These changes are required as the parser previously returned a single result for these queries, it now returns two, but the expected result is still the highest scoring.
e98ff9c to
7415a9f
Compare
7415a9f to
e0ab3bb
Compare
|
The improved https://pelias.github.io/compare/#/v1/autocomplete?text=Calle+Principal+20+B vs. https://pelias.github.io/compare/#/v1/autocomplete?text=Calle+Principal+20+Ba |
|
We may need to revert this is we can't come up with a workaround, one which comes to mind is to strip non-numeric tokens from the It feels like one step forward in support for units and then a step back 😢 |
branched from
stopword-classification, requires #179 be merged first.This PR is an attempt at solving #178 with minimal changes.
However, it seems to solve a longstanding issue which was more widespread, namely having a space between
HouseNumberandUnitNumber:I'm going to have a think about this before merging, it feels 'too easy', I'm sure it comes with some pitfalls.
Closes #178