wof-import: convert iso2 abbr to iso3 for countries and dependencies#83
Open
wof-import: convert iso2 abbr to iso3 for countries and dependencies#83
Conversation
Member
|
Seems like an error in the data if the Any idea how widespread this issue is? |
Member
Author
|
The The shortcode is not always a iso3 since it's also used for regions etc. Here the issue mainly affects dependencies, I found this thanks to an acceptance test on Guam ( Here is the list of all 2 char abbreviations I found in the database:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to add more consistency in abbreviations. In WOF data we can find countries and dependencies with iso2 and iso3 abbreviations.
In pelias/whosonfirst we are using only iso3 abbreviation, I'm porting this feature to spatial (see pelias/whosonfirst/peliasDocGenerators.js)