Re-enable Ethereum onramps - #1311
Merged
Merged
Conversation
✅ Deploy Preview for vrtx-dashboard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The focused quote restriction removal is supported by regression coverage and synchronized security documentation.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Re-enables Ethereum BUY ramps while retaining conservative destination gas prefunding.
Changes:
- Removes Ethereum quote rejection.
- Names and tests the Ethereum funding reserve.
- Documents native gas-dust implications.
File summaries
| File | Description |
|---|---|
docs/security-spec/03-ramp-engine/ephemeral-accounts.md |
Documents destination prefunding and residual gas dust. |
apps/api/src/tests/corridors/brl-onramp-crosschain.scenario.test.ts |
Adds Ethereum quote regression coverage. |
apps/api/src/constants/constants.ts |
Defines the Ethereum reserve constant. |
apps/api/src/api/services/quote/index.ts |
Allows Ethereum BUY quotes. |
apps/api/src/api/services/phases/blocks/core/destination-funding.ts |
Uses the named reserve constant. |
apps/api/src/api/services/phases/blocks/core/destination-funding.test.ts |
Verifies funding-map configuration. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
ebma
changed the title
ebma
force-pushed
the
codex/enable-ethereum-onramps
branch
from
August 4, 2026 17:51
2c0236a to
04183d3
Compare
ebma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ETHEREUM_EPHEMERAL_STARTING_BALANCE_UNITSconstantScope
This PR deliberately keeps the established 0.005 ETH destination reserve so Ethereum enablement remains a small, independently reviewable change. Dynamic destination funding and fee pricing are split into a separate follow-up for broader EVM consideration.
Verification
bun lint:fixbun run verify