fix(sdk): lazily initialize chain websocket APIs - #1314
Merged
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Makes SDK chain API initialization demand-driven and bounded, preventing unavailable WebSockets from blocking HTTP-only ramp flows.
Changes:
- Adds configurable per-network initialization timeouts and structured errors.
- Avoids chain initialization when no transactions require signing.
- Adds BRL regression tests and updates SDK documentation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/sdk/src/VortexSdk.ts |
Defers network initialization until signing is required. |
packages/sdk/src/services/NetworkManager.ts |
Adds bounded initialization and cleanup. |
packages/sdk/src/errors.ts |
Defines network initialization errors. |
packages/sdk/src/types.ts |
Exposes timeout configuration. |
packages/sdk/test/vortexSdk.lazyNetworks.test.ts |
Tests HTTP-only flows and timeout behavior. |
packages/sdk/README.md |
Documents lazy initialization. |
packages/sdk/ARCHITECTURE.md |
Updates network-manager responsibilities. |
.agents/skills/vortex-integration/SKILL.md |
Updates the integration example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun run testinpackages/sdk(49 tests, build, and bundle smoke-load)bun run typecheckinpackages/sdk