Add attributes filter to PCP #560
Open
+408
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esinx
reviewed
Jan 28, 2024
Member
esinx
left a comment
esinx
left a comment
There was a problem hiding this comment.
Minor suggestions & type-related questions!
| break; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We could possibly make this a bit simpler by using .some method!
filterData.selectedAttrs && Object.values(filterData.selectedAttrs).some(selected => selected)
| GSE = "GSE", | ||
| LAW = "LAW", | ||
| MEDICINE = "MED", | ||
| GRADE_MODE = "MODE", // this isn't really a school, but it's used for course attributes |
Member
There was a problem hiding this comment.
Is this something we could split using union types? or is it better left as a one-off? Would love to hear more background behind this decision!
Contributor
Author
There was a problem hiding this comment.
2 reasons
- blindly following the conventions of the rest of this file (it was probably written before union types?)
- easier to guarantee exhaustive matching (?)
I'm not a typescript expert, so I'll defer to you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for course attributes to PCP, including an attribute filter and adding attributes to course details. Attributes include those Wharton, SEAS, SAS, and Nursing, as well as additional ones for GSE, LPS, Grade Mode etc.
TODO: