Stream_df_cholesky_peek: Guarantee data is copied back to shared memory #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the control program could proceed to halt the timer and enter the verification stage w/o guaranteeing the matrix was fully unloaded from the streams to shared memory. This caused verification to fail on single-threaded runs. This was not a problem in multi-threaded runs, presumably because the other threads would be free to finish these copies before the copy of the last block (which the control programs always waited for) happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the control program could proceed to halt the timer and
enter the verification stage w/o guaranteeing the matrix was fully
unloaded from the streams to shared memory. This caused verification
to fail on single-threaded runs. This was not a problem in
multi-threaded runs, presumably because the other threads would be free
to finish these copies before the copy of the last block (which the
control programs always waited for) happened.