Conversation
nastena1606
commented
Apr 17, 2026
nastena1606
commented
- The contributed code is licensed under GPL v2.0
- Contributor Licence Agreement (CLA) is signed
- util/update-modules has been ran
- Documentation updated
- Test suite update
There was a problem hiding this comment.
Pull request overview
Updates the Sphinx documentation branding assets and styling for Percona Toolkit.
Changes:
- Refresh Sphinx project metadata year.
- Replace the Percona logo and favicon SVG assets.
- Update custom Sphinx Material CSS (font stack and accent color) and add new PNG branding assets.
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/user/README | Removes placeholder text from the user docs directory README. |
| config/sphinx-build/conf.py | Updates Sphinx project metadata copyright year. |
| config/sphinx-build/_static/percona-logo.svg | Replaces the documentation logo SVG with a new (Illustrator-exported) version. |
| config/sphinx-build/_static/percona-favicon.svg | Replaces the favicon SVG with a new (Illustrator-exported) version. |
| config/sphinx-build/_static/css/material.css | Updates Sphinx Material CSS branding (font stack + accent color). |
| config/sphinx-build/_static/Percona - One Color - Dark.png | Adds a new PNG branding asset under _static. |
| config/sphinx-build/Percona - One Color - Dark.png | Adds a similarly named PNG branding asset at the Sphinx config root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # General information about the project. | ||
| project = u'Percona Toolkit' | ||
| copyright = u'2025, Percona LLC and/or its affiliates' | ||
| copyright = u'2026, Percona LLC and/or its affiliates' |
There was a problem hiding this comment.
The PR description currently reads like an unfilled contribution checklist and doesn’t describe the intent/impact of the branding asset updates. Please update the PR description to summarize what changed (e.g., which assets/themes are affected) and mark any required checklist items as complete/incomplete.
| # General information about the project. | ||
| project = u'Percona Toolkit' | ||
| copyright = u'2025, Percona LLC and/or its affiliates' | ||
| copyright = u'2026, Percona LLC and/or its affiliates' |
There was a problem hiding this comment.
The top-level Sphinx metadata updates the copyright year to 2026, but there are still hard-coded "2025, Percona LLC and/or its affiliates" strings later in this same config (e.g., in latex_documents/man_pages). Consider updating those too to keep the generated outputs consistent.
| copyright = u'2026, Percona LLC and/or its affiliates' | |
| copyright_year = u'2026' | |
| copyright_holder = u'Percona LLC and/or its affiliates' | |
| copyright_notice = u'%s, %s' % (copyright_year, copyright_holder) | |
| copyright = copyright_notice |
| font-family: "Poppins", "Roboto", Helvetica, Arial, sans-serif; | ||
| color: #653df4; |
There was a problem hiding this comment.
The CSS switches the font stack to include "Poppins", but there is no corresponding font import/asset reference in the Sphinx config or templates, so most builds will fall back to Roboto/Helvetica and the branding change won’t actually apply. Consider either adding an explicit webfont load (e.g., via an added CSS @import or a template in the theme) or dropping Poppins from the stack if it’s not intended to be bundled.
it-percona
temporarily deployed
to
Update-branding-assets - percona-toolkit PR #1116
Render
Destroyed
nastena1606
force-pushed
the
Update-branding-assets
branch
from
b227a07 to
9f39be9
Compare
