Skip to content

Conversation

@emollier
Copy link

As initially identified in Debian bug #1093442, starting with Perl 5.40, there is a collision on done_testing subroutine declaration causing the following test failure:

Overwriting existing sub 'main::done_testing' with sub 'done_testing' exported by Test::Modern at t/integration-basic.t line 29.

#   Failed test 'no (unexpected) warnings (via done_testing)'
#   at t/integration-basic.t line 82.
# Looks like you failed 1 test of 7.
t/integration-basic.t ......
[…]
not ok 7 - no (unexpected) warnings (via done_testing)

Ensuring fully qualified use of Test::More subroutines allows resolution of the namespace collision via a "require" import instead of a "use".

As initially identified in [Debian bug #1093442], starting with Perl
5.40, there is a collision on done_testing subroutine declaration
causing the following test failure:

	Overwriting existing sub 'main::done_testing' with sub 'done_testing' exported by Test::Modern at t/integration-basic.t line 29.

	#   Failed test 'no (unexpected) warnings (via done_testing)'
	#   at t/integration-basic.t line 82.
	# Looks like you failed 1 test of 7.
	t/integration-basic.t ......
	[…]
	not ok 7 - no (unexpected) warnings (via done_testing)

Ensuring fully qualified use of Test::More subroutines allows
resolution of the namespace collision via a "require" import instead
of a "use".

[Debian bug #1093442]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1093442

Signed-Off-By: Étienne Mollier <[email protected]>
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants