Skip to content

fix: preserve npm package paths in runtime inputs - #117

Merged
longlho merged 1 commit into
mainfrom
codex/preserve-npm-runtime-inputs
Oct 9, 2026
Merged

longlho merged 1 commit into
mainfrom
codex/preserve-npm-runtime-inputs

Conversation

@longlho

@longlho longlho commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Why

Runtime-only directory filtering can relocate npm package trees created in the consumer repository. Node follows compiled modules to their real build-output paths and resolves packages there, outside the relocated runfiles aliases. A warm workspace can hide this dependency on undeclared original outputs; sandboxed CI with minimal output materialization can fail with Cannot find package.

Changes

  • Preserve files and directory artifacts under node_modules, as already done for external-repository and explicitly supplied runtime packages.
  • Continue filtering workspace source/debug metadata and pruning maps from application asset directories.
  • Extend the public-rule regression fixture with a real npm dependency and assert that its original package artifacts remain declared runtime inputs. The assertion fails before this fix.

No public API or cache-policy changes.

@longlho
longlho marked this pull request as ready for review October 9, 2026 04:48
@longlho
longlho enabled auto-merge (squash) October 9, 2026 04:48
@longlho
longlho merged commit 4187833 into main Oct 9, 2026
16 checks passed
@longlho
longlho deleted the codex/preserve-npm-runtime-inputs branch October 9, 2026 04:57
longlho pushed a commit that referenced this pull request Oct 10, 2026
🤖 I have created a release *beep* *boop*
---


## 3.9.0 (2026-10-09)

## What's Changed
* feat: prune source maps from browser input directories by @longlho in
#114
* fix: let callers control browser test selection by @longlho in
#116
* fix: preserve npm package paths in runtime inputs by @longlho in
#117
* fix: allow remote caching for local browser tests by @longlho in
#119
* fix: leave host browser execution restrictions to callers by @longlho
in #120
* feat: aggregate E2E suites in local Playwright UI by @longlho in
#121
* fix: resolve caller data paths in Playwright UI by @longlho in
#122
* fix: build Playwright UI bundles as declared Bazel outputs by @longlho
in #123


**Full Changelog**:
v3.8.1...v3.9.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant