Repository navigation
Conversation
longlho
marked this pull request as ready for review
October 9, 2026 11:06
longlho
enabled auto-merge (squash)
October 9, 2026 11:06
BREAKING CHANGE: Remove runtime_only. Declare required source and debug files explicitly in data.
longlho
force-pushed
the
codex/always-filter-runtime-inputs
branch
from
October 9, 2026 11:06
06cbf07 to
24dc193
Compare
longlho
disabled auto-merge
October 9, 2026 11:07
Contributor
Author
|
Closing: retain the upstream runtime_only option. The consumer wrapper will stop exposing it and explicitly pass True instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Compiled browser inputs should contain runtime artifacts by default, without a separate switch that reintroduces transitive source and debug files into test cache keys.
Changes
runtime_onlyfrom the shared browser API and internal input rule. Runtime filtering is unconditional for compiled inputs and shell assets.data, npm/runtime packages, and snapshot inputs unfiltered. Callers that need sources or maps at runtime must declare them as data.Existing callers using the default behavior are unchanged. Callers passing
runtime_onlymust remove that argument; callers that previously disabled filtering must declare any required source/debug inputs explicitly.