Skip to content

refactor!: always filter compiled browser runtime inputs - #118

Closed
longlho wants to merge 1 commit into
mainfrom
codex/always-filter-runtime-inputs
Closed

longlho wants to merge 1 commit into
mainfrom
codex/always-filter-runtime-inputs

Conversation

@longlho

@longlho longlho commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Why

Compiled browser inputs should contain runtime artifacts by default, without a separate switch that reintroduces transitive source and debug files into test cache keys.

Changes

  • Remove runtime_only from the shared browser API and internal input rule. Runtime filtering is unconditional for compiled inputs and shell assets.
  • Keep explicitly declared data, npm/runtime packages, and snapshot inputs unfiltered. Callers that need sources or maps at runtime must declare them as data.
  • Remove obsolete enabled/disabled test variants while retaining coverage of source exclusion, directory map pruning, explicit data, runfile aliases, and original npm artifact paths.
  • Document the explicit-data path for source-level debugging.

Existing callers using the default behavior are unchanged. Callers passing runtime_only must remove that argument; callers that previously disabled filtering must declare any required source/debug inputs explicitly.

@longlho longlho changed the title Remove runtime_only and always filter compiled browser inputs refactor: always filter compiled browser runtime inputs Oct 9, 2026
@longlho
longlho marked this pull request as ready for review October 9, 2026 11:06
@longlho
longlho enabled auto-merge (squash) October 9, 2026 11:06
BREAKING CHANGE: Remove runtime_only. Declare required source and debug files explicitly in data.
@longlho
longlho force-pushed the codex/always-filter-runtime-inputs branch from 06cbf07 to 24dc193 Compare October 9, 2026 11:06
@longlho longlho changed the title refactor: always filter compiled browser runtime inputs refactor!: always filter compiled browser runtime inputs Oct 9, 2026
@longlho
longlho disabled auto-merge October 9, 2026 11:07
@longlho

longlho commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing: retain the upstream runtime_only option. The consumer wrapper will stop exposing it and explicitly pass True instead.

@longlho longlho closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant