Support for multipart and files #177
Conversation
gtg-bantonio
changed the title
gtg-bantonio
force-pushed
the
4.x
branch
2 times, most recently
from
bca58a0 to
3f615c2
Compare
|
Just encountered the multipart form issue myself and can confirm this fixes it. In case its useful for the maintainers, I've just pushed up a repo demonstrating the issue: https://github.com/duncanmcclean/pestphp-formdata-bug (I haven't tested the file uploads side though!) |
|
I have faced the same issue and this PR fixes it. Hopefully it can be merged. |
# Conflicts: # src/Drivers/LaravelHttpServer.php # tests/Unit/Drivers/Laravel/LaravelHttpServerTest.php
- Removed the multibyte management for the strings, because with empty PDFs and DOCX does not find the boundary string correctly.
- Remove the temp name if the file has an error. - Standardized the name with the PHP conventions.
- Converted the non-selected files into nulls.
|
@gtg-bantonio any idea why this PR was closed? It seemed to solve a real issue. |
|
@akulmehta Sorry, my bad, I was updating the branch to keep it up with the last changes |
|
@gtg-bantonio no apologies needed. I really want this to be merged - thank you for your help. |
akulmehta
left a comment
akulmehta
left a comment
There was a problem hiding this comment.
I checked out the branch and everything seems to be working. This PR really helps fix an issue when using multipart form data, the browser testing fails because the multipart data in the request is empty due to how the data is being parsed.
3 participants
Uh oh!
There was an error while loading. Please reload this page.