Skip to content

fix: make --no-cache truly bypass caching instead of just flushing #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-moh wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

fix: make --no-cache truly bypass caching instead of just flushing #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Analyser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class Analyser
* @param array<int, string> $files
* @param Closure(Result): void $callback
*/
public static function analyse(array $files, Closure $postProcessedFile, Closure $onProcessedFile, Cache $cache): void
public static function analyse(array $files, Closure $postProcessedFile, Closure $onProcessedFile, ?Cache $cache): void
{
$testCase = new TestCaseForTypeCoverage('dummy');

Expand All @@ -31,7 +31,7 @@ public static function analyse(array $files, Closure $postProcessedFile, Closure
$filesTouched = [];

foreach ($files as $file) {
if ($cache->has($file)) {
if ($cache !== null && $cache->has($file)) {
[$file, $errors, $ignored] = $cache->get($file);

$result = Result::fromPHPStanErrors($file, $errors, $ignored);
Expand Down Expand Up @@ -95,7 +95,7 @@ private static function analyseChunks(
TestCaseForTypeCoverage $testCase,
Closure $postProcessedFile,
Closure $onProcessedFile,
Cache $cache,
?Cache $cache,
bool $useAsync = true,
): void {
$promises = [];
Expand Down Expand Up @@ -123,7 +123,7 @@ private static function analyseChunks(
$errors = array_values($errors);
$ignored = array_values($ignored);

$cache->persist($file, [$file, $errors, $ignored]);
$cache?->persist($file, [$file, $errors, $ignored]);

$result = Result::fromPHPStanErrors($file, $errors, $ignored);

Expand Down
6 changes: 4 additions & 2 deletions src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ public function handleOriginalArguments(array $arguments): void
return;
}

if ($this->hasArgument('--no-cache', $arguments)) {
$noCache = $this->hasArgument('--no-cache', $arguments);

if ($noCache) {
$this->cache->flush();
}

Expand Down Expand Up @@ -234,7 +236,7 @@ function (Result $result) use ($terminalWidth): void {
</div>
HTML);
},
$this->cache,
$noCache ? null : $this->cache,
);

$coverage = array_sum($totals) / count($totals);
Expand Down