Skip to content

Fix "skip auto close" annotation key #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fix "skip auto close" annotation key #50

merged 1 commit into from
Apr 15, 2025

Conversation

@superbrothers
Copy link
Member

@superbrothers superbrothers commented Apr 15, 2025

This PR fixes "atg-skip-auto-close" annotation key to atg_skip_auto_close.

In Prometheus, - is not allowed in label and annotation key.

Prometheus metrics and label names are written in snake_case. Converting camelCase to snake_case is desirable, though doing so automatically doesn’t always produce nice results for things like myTCPExample or isNaN so sometimes it’s best to leave them as-is.

https://prometheus.io/docs/instrumenting/writing_exporters/#naming

@superbrothers superbrothers requested a review from wafrelka April 15, 2025 08:56
@wafrelka wafrelka added the minor Bump minor version in next release label Apr 15, 2025
wafrelka
wafrelka approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@wafrelka wafrelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also overlooked this... Thank you.

@superbrothers superbrothers removed the minor Bump minor version in next release label Apr 15, 2025
@superbrothers superbrothers merged commit 969b59b into master Apr 15, 2025
2 checks passed
@superbrothers superbrothers deleted the fix-annotation-key branch April 15, 2025 09:13
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wafrelka wafrelka wafrelka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@superbrothers @wafrelka