CMake enforce Protobuf 2.6.1 #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdshin
requested changes
Feb 1, 2019
CMakeLists.txt
Outdated
| # https://github.com/protocolbuffers/protobuf/releases | ||
| # Let's be safe and require protobuf 2.6.1: | ||
| set(REQUIRED_PROTOBUF_VERSION "2.6.1") | ||
| message(STATUS "REQUIRED PROTOBUF_VERSION= ${REQUIRED_PROTOBUF_VERSION}") |
Contributor
There was a problem hiding this comment.
This message seems redundant because succeeding find_package checks the version and print similar message.
CMakeLists.txt
Outdated
| # As today, it s not sure that menoh will work perfectly with future version of protobuf (2.7.0, ...) : | ||
| # https://github.com/protocolbuffers/protobuf/releases | ||
| # Let's be safe and require protobuf 2.6.1: | ||
| set(REQUIRED_PROTOBUF_VERSION "2.6.1") |
Contributor
There was a problem hiding this comment.
REQUIRED_PROTOBUF_VERSION is not used exceptfind_package if succeeding message is removed. So we can write the version string 2.6.1 directly in find_package statement.
Contributor
|
Thank you for the PR. I made some comments. Please check. @WilliamTambellini |
Author
|
done |
Contributor
|
Thank you! I know you are working for onnx about the same issue. onnx/onnx#1794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.