fix: raise RuntimeError when failed to generate an answer #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhrkw
commented
Aug 26, 2025
| json.dump(data, f, indent=2, ensure_ascii=False) | ||
|
|
||
| result["num_trials"] = min([len(x) for x in data.values()]) | ||
| result["num_trials"] = max([len(x) for x in data.values()]) |
Contributor
Author
There was a problem hiding this comment.
Putting num_trials in config.json seems appropriate.
imos
approved these changes
Sep 2, 2025
yhrkw
force-pushed
the
unraise-not-answered
branch
from
7ac75fd to
6fb652e
Compare
imos
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several models, they fail during generation and raise
RuntimeError. This appears to occur with both pre-trained models and API-based models.We will include generation success/failure status to
trial_*.jsonwhile excluding it from score calculations.