minor changes in headers to make tick work in my environment. I beli…#13
Open
robertramey wants to merge 1 commit intopfultz2:masterfrom
Open
minor changes in headers to make tick work in my environment. I beli…#13robertramey wants to merge 1 commit intopfultz2:masterfrom
robertramey wants to merge 1 commit intopfultz2:masterfrom
Conversation
…ve they are of general usage.
pfultz2
reviewed
Aug 7, 2017
|
|
||
| #include "detail/matches.h" | ||
| #include "detail/pp.h" | ||
| #include "integral_constant.h" |
Owner
There was a problem hiding this comment.
The include paths should not use relative paths.
pfultz2
reviewed
Aug 7, 2017
| RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}" | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/tick/detail/*.h" | ||
| ) | ||
| add_custom_target(tick_include_detail SOURCES ${tick_include}) |
Owner
There was a problem hiding this comment.
This doesn't include all the header files, and I don't like the idea of creating a target for each include directory.
Owner
|
There is merge conflict, so this cannot be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eve they are of general usage.