Skip to content

Fix type inference for fields with intermediate pipe filters #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levkk merged 1 commit into from
May 21, 2026
+19 −21
Merged

Fix type inference for fields with intermediate pipe filters #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scripts/generate-schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,18 @@
# Template `if .Values.X` is a truthiness check, not a type indicator.
CONTEXT_PATTERNS = [
# pgdog.intval → integer (accepts int or underscore-separated string)
(re.compile(r'include\s+"pgdog\.intval".*\.Values\.{path}'), "integer"),
(re.compile(r'\.Values\.{path}.*\|\s*int'), "integer"),
(re.compile(r'include\s+"pgdog\.intval".*\.Values\.{path}\b'), "integer"),
(re.compile(r'\.Values\.{path}\b.*\|\s*int\b'), "integer"),
# | toYaml / with .Values.X → object
(re.compile(r"\.Values\.{path}\s*\|\s*toYaml"), "object"),
(re.compile(r"toYaml\s+\.Values\.{path}"), "object"),
(re.compile(r"with\s+\.Values\.{path}\s"), "object"),
(re.compile(r"\.Values\.{path}\b\s*\|\s*toYaml"), "object"),
(re.compile(r"toYaml\s+\.Values\.{path}\b"), "object"),
(re.compile(r"with\s+\.Values\.{path}\b\s"), "object"),
# | toToml → array
(re.compile(r"\.Values\.{path}\s*\|\s*toToml"), "array"),
(re.compile(r"\.Values\.{path}\b\s*\|\s*toToml"), "array"),
# range .Values.X → array
(re.compile(r"range\s+\.Values\.{path}"), "array"),
# | quote → string
(re.compile(r"\.Values\.{path}\s*\|\s*quote"), "string"),
(re.compile(r"range\s+\.Values\.{path}\b"), "array"),
# | quote → string (allow intermediate filters like `| default "foo" | quote`)
(re.compile(r"\.Values\.{path}\b[^}]*\|\s*quote"), "string"),
]


Expand Down
22 changes: 10 additions & 12 deletions values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,14 @@
"off"
]
},
"logMinDurationParse": {
"type": "integer",
"minimum": 0
},
"logQuerySampleLength": {
"type": "integer",
"minimum": 0
},
"lsnCheckDelay": {
"type": "integer",
"minimum": 0
Expand Down Expand Up @@ -901,8 +909,7 @@
"description": "Delay before stopping container to allow endpoint updates"
},
"preparedStatements": {
"type": "integer",
"minimum": 0
"type": "string"
},
"preparedStatementsLimit": {
"type": "integer",
Expand Down Expand Up @@ -1168,14 +1175,6 @@
"type": "object",
"description": "Container readiness probe configuration"
},
"logMinDurationParse": {
"type": "integer",
"minimum": 0
},
"logQuerySampleLength": {
"type": "integer",
"minimum": 0
},
"regexParserLimit": {
"type": "integer",
"minimum": 0
Expand Down Expand Up @@ -1491,8 +1490,7 @@
}
},
"twoPhaseCommit": {
"type": "boolean",
"minimum": 0
"type": "boolean"
},
"twoPhaseCommitAuto": {
"type": "boolean"
Expand Down
Loading