feat: add query_log_stdout config for pgcat-style query logging#1015
Merged
Conversation
Log every query to stdout when enabled via pgdog.toml or PGDOG_QUERY_LOG_STDOUT, using format [pool: db][user: user] query
|
|
marcomicera
changed the title
query_log_stdout config for pgcat-style query logging
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Adding tests to cover these 6 missing lines... 👨💻 |
levkk
reviewed
May 28, 2026
levkk
reviewed
May 28, 2026
Put the query first and append database/user metadata at the end (`query [database: db, user: user]`) instead of the pgcat-style prefix. Also rename "pool" to "database" in the suffix for consistency.
Load query_log_stdout once per request in Client::buffer and log via QueryEngine before parsing, so queries are logged even when the parser is bypassed (e.g. query_parser = off).
levkk
approved these changes
May 28, 2026
Collaborator
levkk
left a comment
levkk
left a comment
There was a problem hiding this comment.
Cool! Let's let CI run but otherwise, good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
query_log_stdoutgeneral config option that logs every query to stdout in pgcat-style format:[pool: db][user: user] query.pgdog.tomlorPGDOG_QUERY_LOG_STDOUTfalseTest plan
query_log_stdout = trueand confirm queries appear in logs