Skip an intermediate Vec in Server::fetch_all#1021
Merged
Conversation
This in theory could potentially do more work in the error case, since we're running `T::from` on all rows before the error occurred, but `From` is generally expected to be quite cheap, and is unlikely to be significantly more costly than the intermediate Vec. And we will *always* be doing less work in the success case which is more important
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This in theory could potentially do more work in the error case, since we're running
T::fromon all rows before the error occurred, butFromis generally expected to be quite cheap, and is unlikely to be significantly more costly than the intermediate Vec. And we will always be doing less work in the success case which is more important