Improved warning UX for bad asset cases + generated icon#2
Open
CianNoonan wants to merge 2 commits intophi-lira:masterfrom
Open
Improved warning UX for bad asset cases + generated icon#2CianNoonan wants to merge 2 commits intophi-lira:masterfrom
CianNoonan wants to merge 2 commits intophi-lira:masterfrom
Conversation
…so allow textures to now being read even if there is a size mismatch(!)
…th standard texture assets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is taking some design liberty on the UX.
Importantly I also now allow a smart texture to be created from images that do not match in size. This does create some artefacts as shown below but the case is warned to the end-user so they can investigate and decide what to do. In future, these inputs could maybe be resized on the CPU with a nicer algo to mitigate this issue.
Original
Output
-- Size mismatch
-- Compressed input texture (The way I detect whether a format is compressed could be improved but there isn't a simple built-in check to find this out)
-- In order to match basic texture UX the smart textures icon is now a small version of the output texture.