Fix generation of JSON feed#177
Merged
Merged
Conversation
Likely broke in a709efc
In addition, add the site build step to pull request actions as a smoke test
github-actions Bot
added a commit
that referenced
this pull request
May 31, 2026
* Fix generation of JSON feed * Prevent building of site when species is missing in sculpin_site.yml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to A Field Guide to Elephpants. To speed up approval of your contribution, please review the following checklist:
This PR contains two commits:
Feed generation likely broke in a709efc
sculpin_site.ymlRunning
vendor/bin/sculpin generatewill now fail if a new category is added without its species being declared insculpin_site.yml. This check occurs when running locally and is also added to each PR as a smoke test. Finally, we also validate that the JSON feed was generated, and that the JSON is valid.