Skip to content

Conversation

@studzien
Copy link
Contributor

@studzien studzien commented Nov 3, 2025

This PR adds support for passing deflate_options to the underlying Cowboy WebSocket adapter, allowing users to configure deflate compression settings for their WebSocket connections.

Changes

  • Added deflate_options to the list of supported connection options in WebSockAdapter.upgrade/4
  • Updated documentation to mention the new option
  • The option is passed through to Cowboy as deflate_opts (matching Cowboy's expected parameter name)

Compatibility

This change is backwards compatible as it only adds a new optional configuration parameter.

@studzien
Copy link
Contributor Author

studzien commented Nov 4, 2025

Hello @mtrudel.
Is there any chance to include this (or an equivalent) soon? We still rely on Cowboy at the moment, and ideally, we don't use our own fork for production deployment (although that's going to be fine temporarily).

Thanks!

@mtrudel
Copy link
Member

mtrudel commented Nov 5, 2025

Apologies! I must have missed the original notification for this PR and it fell through the cracks! Merging right away

@mtrudel mtrudel merged commit 8eca1c0 into phoenixframework:main Nov 5, 2025
6 of 9 checks passed
@mtrudel
Copy link
Member

mtrudel commented Nov 5, 2025

Released as 0.5.9. Apologies again for the extreme tardiness.

@studzien
Copy link
Contributor Author

studzien commented Nov 5, 2025

Thank you! No worries at all! I wasn't sure if there was a notification involved (as I couldn't add a reviewer or assignee), so I pinged you in the comment.

Thanks again! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants