zend_API: Add Z_PARAM_ENUM_NAME() #20898
Open
+34
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
requested review from
DanielEScherzer,
devnexen,
dstogov,
kocsismate,
ndossche and
zeriyoshi
as code owners
TimWolla
force-pushed
the
z-param-enum-name
branch
from
873e4c7 to
43e9fd5
Compare
Girgias
reviewed
Jan 11, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Makes sense to me. Just a few questions regarding const qualifiers.
ndossche
approved these changes
Jan 11, 2026
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
No further remarks from my side. This is nicer.
I wonder whether we should also add the _OR_NULL & _EX variants etc.
Member
Author
I feel that a nullable enum is something that is rarely needed, since the "null case" could just be part of the enum with a proper name. |
It is becoming increasingly common to have enum parameters on internal functions. Manually turning the singleton enum object into the case name is verbose, especially for optional parameters. Add a new `Z_PARAM_ENUM_NAME()` helper to directly retrieve the case name.
TimWolla
force-pushed
the
z-param-enum-name
branch
from
43e9fd5 to
ac20d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is becoming increasingly common to have enum parameters on internal functions. Manually turning the singleton enum object into the case name is verbose, especially for optional parameters.
Add a new
Z_PARAM_ENUM_NAME()helper to directly retrieve the case name.