Skip to content

Conversation

@arnaud-lb
Copy link
Member

This fixes some oversights from GH-19022:

  • Use the newly introduced zend_call_trampoline_arginfo in zend_get_call_trampoline_func().
  • Update the arg name to arguments instead of args, to match the documentation: https://www.php.net/__call#language.oop5.overloading.methods
  • Use the original arg_info when creating an FCC of a trampoline to reduce duplication

None of these changes are observable, but this is cleaner, and this becomes observable in GH-20848.

@arnaud-lb arnaud-lb marked this pull request as ready for review January 16, 2026 12:39
@arnaud-lb arnaud-lb requested a review from dstogov as a code owner January 16, 2026 12:39
@arnaud-lb arnaud-lb merged commit 6e6a850 into php:master Jan 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants