Minimalize the react-famous library, remove examples and build-system dependencies.#18
Open
trusktr wants to merge 25 commits intopilwon:mixed-modefrom
Open
Minimalize the react-famous library, remove examples and build-system dependencies.#18trusktr wants to merge 25 commits intopilwon:mixed-modefrom
trusktr wants to merge 25 commits intopilwon:mixed-modefrom
Conversation
… other scripts for various target formats.
This was referenced Aug 3, 2015
Open
…therwise if they use classes from a different famous global, then they will have duplicate Singletons of some classes (like the FamousEngine for example) and that will cause unexpected error that are hard to debug. This would need to be well documented. What do you think @pilwon?
…for global users. @pilwon, maybe we can instead make a script that strips out the React and Famous imports, then we tell the user to make sure to include both React and Famous in their project. TODO: The check for window or global can be better, so if window or global aren't defined then it won't fail.
Use the index.js file for the global, and just build to UMD format with webpack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP, don't merge!)
This will minimalize the react-famous library, to make it as consumable as possible, not just via NPM, but via GitHub (and hence bower and jspm) as well. Some package managers get libraries directly from GitHub, so keeping the library as lean as possible and agnostic to build systems as possible will make the library the most consumable in any environment. People will also be able to choose between the built version of the library, or the original form of the library and compile it themselves; they'll have maximum flexibility and freedom to use the library the way they want.
We'll put the example up in a separate repo, or perhaps just use the react-famous-seed repo as the goto example.
We'll also update the README with steps on getting started with the most common/standard build systems.