Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 7, 2025

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • No code

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.54%. Comparing base (adb26b9) to head (a05a3c6).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   14.72%   11.54%   -3.17%     
==========================================
  Files          74      124      +50     
  Lines        9146    10378    +1232     
==========================================
- Hits         1346     1198     -148     
- Misses       7629     9009    +1380     
  Partials      171      171              
Flag Coverage Δ
unittests 11.54% <ø> (-3.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 7, 2025

/cc @xhebox @wuhuizuo

@wuhuizuo
Copy link

wuhuizuo commented Nov 7, 2025

/cc @kaaaaaaang

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lack the token: ${{ secrets.CODECOV_TOKEN }} part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be ok. It might use a generic and/or github token. We can switch this later when needed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 12, 2025

/cc @kaaaaaaang @zimulala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants