Skip to content

feat: support independent kvengine remote worker and compactor worker#6787

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
liubog2008:liubo02/fix-worker-ref
Apr 2, 2026
Merged

feat: support independent kvengine remote worker and compactor worker#6787
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
liubog2008:liubo02/fix-worker-ref

Conversation

@liubog2008
Copy link
Copy Markdown
Member

@liubog2008 liubog2008 commented Mar 31, 2026

kvengine remote worker should always use default worker ref. It unexpectedly uses the copr ref. Fix it by introducing a new feature gate.

compactor ref is introduced.

@ti-chi-bot ti-chi-bot bot requested a review from shonge March 31, 2026 09:37
@github-actions github-actions bot added the v2 for operator v2 label Mar 31, 2026
@ti-chi-bot ti-chi-bot bot added the size/L label Mar 31, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.11%. Comparing base (2af843f) to head (8e7d7eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6787      +/-   ##
==========================================
- Coverage   37.12%   37.11%   -0.01%     
==========================================
  Files         390      390              
  Lines       22347    22353       +6     
==========================================
  Hits         8297     8297              
- Misses      14050    14056       +6     
Flag Coverage Δ
unittest 37.11% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: liubo02 <liubo02@pingcap.com>
Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008 liubog2008 force-pushed the liubo02/fix-worker-ref branch from f9f0b87 to 8e7d7eb Compare April 2, 2026 03:15
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-02 06:53:31.053061524 +0000 UTC m=+420816.258421571: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 2, 2026
@ti-chi-bot ti-chi-bot bot merged commit 6a1bbac into pingcap:main Apr 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants