fix: honor --stderrthreshold flag when --logtostderr is enabled (#6786)#6789
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-1.6from Apr 3, 2026
Merged
Conversation
When logtostderr is enabled in the backup manager, klog's legacy behavior ignores the stderrthreshold flag. This opts into the fixed behavior introduced in klog v2.130.0 by setting legacy_stderr_threshold_behavior=false. Also adds proper error handling for the existing bare pflag.Set() call. See: kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
Update k8s.io/klog/v2 from v2.110.1 to v2.140.0 and github.com/go-logr/logr from v1.3.0 to v1.4.1 in pkg/apis and pkg/client submodules to match the main module versions. This fixes the check-modules CI verification failure. Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
ti-chi-bot
added
contribution
first-time-contributor
ok-to-test
size/M
type/cherry-pick-for-release-1.6
v2
|
|
Member
|
/test pull-e2e-kind-basic |
1 similar comment
Member
|
/test pull-e2e-kind-basic |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6786
What this PR does
The backup manager calls
pflag.Set("logtostderr", "true")which enables klog's logtostderr mode. However, due to klog's legacy behavior, the--stderrthresholdflag is silently ignored whenlogtostderris true.This PR:
pflag.Set("logtostderr", "true")calllegacy_stderr_threshold_behavior=false— disables the legacy overridestderrthreshold=INFO— preserves the current default behaviorAfter this change, the
--stderrthresholdflag works as expected in the backup manager.Why
See upstream fix: kubernetes/klog#432