Skip to content

feat: support mount sa token explicitly if automount is false#6815

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-1.xfrom
liubog2008:liubo02/use-sa-token-projection
Apr 13, 2026
Merged

feat: support mount sa token explicitly if automount is false#6815
ti-chi-bot[bot] merged 3 commits intopingcap:release-1.xfrom
liubog2008:liubo02/use-sa-token-projection

Conversation

@liubog2008
Copy link
Copy Markdown
Member

@liubog2008 liubog2008 commented Apr 10, 2026 •
edited
Loading

  • If automountServiceAccountToken is set to false, br and discovery should mount sa token explicitly

@ti-chi-bot ti-chi-bot bot added the size/XL label Apr 10, 2026
@liubog2008 liubog2008 force-pushed the liubo02/use-sa-token-projection branch from d4e621d to 8a08847 Compare April 10, 2026 08:25
@liubog2008
feat: support mount sa token explicitly for discovery/br if automount…
8bc791e 
… is false

Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008
fix verify
f68f202 
Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008
fix verify
8adc6e4 
Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008 liubog2008 force-pushed the liubo02/use-sa-token-projection branch from b17e13e to 8adc6e4 Compare April 10, 2026 15:54
@liubog2008
Copy link
Copy Markdown
Member Author

liubog2008 commented Apr 11, 2026

/retest

@liubog2008
Copy link
Copy Markdown
Member Author

liubog2008 commented Apr 13, 2026

/test pull-e2e-kind-basic

@liubog2008
Copy link
Copy Markdown
Member Author

liubog2008 commented Apr 13, 2026

e /test pull-e2e-kind-basic

@liubog2008
Copy link
Copy Markdown
Member Author

liubog2008 commented Apr 13, 2026

/test pull-e2e-kind-basic

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 13, 2026
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-13 07:48:08.388926052 +0000 UTC m=+1374493.594286109: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 0344b9b into pingcap:release-1.x Apr 13, 2026
15 checks passed
@liubog2008
Copy link
Copy Markdown
Member Author

liubog2008 commented Apr 13, 2026

/cherry-pick release-1.6

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 13, 2026
Closed
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Apr 13, 2026

@liubog2008: new pull request created to branch release-1.6: #6823.

Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liubog2008 liubog2008 mentioned this pull request Apr 13, 2026
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 14, 2026
@liubog2008
feat: support mount sa token explicitly if automount is false (#6815) (…
9f72356 
…#6826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees

No one assigned

Labels

approved lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liubog2008 @ti-chi-bot @csuzhangxc