-
Notifications
You must be signed in to change notification settings - Fork 6.1k
br: fix region scan checker #64530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
br: fix region scan checker #64530
Conversation
Signed-off-by: Jianjun Liao <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64530 +/- ##
================================================
+ Coverage 72.6805% 74.8699% +2.1894%
================================================
Files 1866 1889 +23
Lines 506361 516414 +10053
================================================
+ Hits 368026 386639 +18613
+ Misses 115940 105951 -9989
- Partials 22395 23824 +1429
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
please help push PD side to accept this request tikv/pd#8442 |
Signed-off-by: Jianjun Liao <[email protected]>
Got it. I will try |
| } | ||
|
|
||
| func checkRegionConsistency(startKey, endKey []byte, regions []*RegionInfo) error { | ||
| func checkRegionConsistency(startKey, endKey []byte, regions []*RegionInfo, limitted bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment for limited?
| lastRegions = regions | ||
|
|
||
| if err = checkRegionConsistency(startKey, endKey, regions); err != nil { | ||
| if err = checkRegionConsistency(startKey, endKey, regions, false); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

What problem does this PR solve?
Issue Number: close #64514
Problem Summary:
the store id of region leader scanned may be 0.
What changed and how does it work?
add region scan checker to check the leader store id after each region scan API.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.