Delete legacy emitter files replaced by component architecture#78
Draft
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-alloy-foundation-v2from
Draft
Delete legacy emitter files replaced by component architecture#78FionaBronwen wants to merge 2 commits intofionabronwen/graphql-alloy-foundation-v2from
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-alloy-foundation-v2from
Conversation
FionaBronwen
force-pushed
the
fionabronwen/graphql-delete-legacy-v2
branch
from
c664ca3 to
9d65cbe
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-alloy-foundation-v2
branch
6 times, most recently
from
a225a7d to
8f1da87
Compare
Introduce the foundation for the component-based GraphQL emitter: - Build/config: Add @alloy-js/core, @alloy-js/graphql dependencies, configure JSX transpilation (tsconfig, vitest) - Context system: GraphQLSchemaContext with ClassifiedTypes, ModelVariants, and ScalarVariant interfaces - Field components: Field, OperationField, and GraphQLTypeExpression for rendering model properties and operations as GraphQL SDL - Type resolution: GraphQLTypeExpression handles scalars, models, enums, unions, arrays, and nullability using an isInput prop to distinguish input vs output context - Scalar mappings: Add getGraphQLBuiltinName() for built-in scalar identity checks
FionaBronwen
force-pushed
the
fionabronwen/graphql-alloy-foundation-v2
branch
from
8f1da87 to
8b51ca4
Compare
FionaBronwen
changed the base branch from
fionabronwen/graphql-alloy-foundation-v2
to
feature/graphql
FionaBronwen
force-pushed
the
fionabronwen/graphql-delete-legacy-v2
branch
from
9d65cbe to
48403d0
Compare
FionaBronwen
changed the base branch from
feature/graphql
to
fionabronwen/graphql-alloy-foundation-v2
Removes the old procedural emitter implementation now fully replaced by the Alloy JSX component-based emitter: - graphql-emitter.ts (old emitter implementation) - schema-emitter.ts (old schema-specific emitter) - registry.ts (old type registry) - type-maps.ts (old type mapping logic) - emitter.test.ts (old emitter tests) Replaces emitter.ts with a no-op stub so the package still conforms to the TypeSpec emitter interface. The real component-based emitter is added in the next PR in the chain.
FionaBronwen
force-pushed
the
fionabronwen/graphql-delete-legacy-v2
branch
from
48403d0 to
806adc8
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-alloy-foundation-v2
branch
from
8b51ca4 to
8f411e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy (non-component) emitter implementation, clearing the way for the new Alloy component-based emitter in follow-up PRs.
graphql-emitter.ts,schema-emitter.ts,registry.ts,type-maps.tstest/emitter.test.ts(tests for the legacy emitter)emitter.tswith a placeholder stub ($onEmitis a no-op until the new emitter lands)Test plan
npm run buildsucceedsnpm test— all remaining tests pass (deleted tests were for removed code)