Add Object, Interface, and Input type components with tests#80
Draft
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-components-1from
Draft
Add Object, Interface, and Input type components with tests#80FionaBronwen wants to merge 2 commits intofionabronwen/graphql-components-1from
FionaBronwen wants to merge 2 commits intofionabronwen/graphql-components-1from
Conversation
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
d5eb811 to
9ce5acc
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
from
aa5f67f to
915dfa1
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
9ce5acc to
e8903e3
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
from
915dfa1 to
292ff4b
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
e8903e3 to
46bd2fe
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
from
292ff4b to
e647811
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
2 times, most recently
from
f379460 to
c9c7af2
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
from
e647811 to
79f53c2
Compare
2 tasks
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
c9c7af2 to
4178df3
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
2 times, most recently
from
41fbefb to
8a187c4
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
4178df3 to
5195591
Compare
Add field-bearing type components that use the Field infrastructure (already present from the parent branch): - ObjectType: renders object types with fields, @compose interfaces, and @operationFields support - InterfaceType: renders interface type definitions with fields - InputType: renders input types with automatic Input suffix when a model appears in both input and output positions 17 new component tests covering: basic field rendering, doc comments, optional/nullable fields, array/list types, deprecated fields, interface implementation via @compose, and Input suffix logic.
…ed imports - Add explanatory comment on getComposition/iface.name in object-type.tsx clarifying that pre-mutation names match post-mutation names (mutation engine doesn't rename models) - Remove unused `type Model` import from all G2 test files
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-1
branch
from
5195591 to
c288111
Compare
FionaBronwen
force-pushed
the
fionabronwen/graphql-components-2
branch
from
8a187c4 to
ffa9c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the field-bearing type components that use the
Fieldinfrastructure from the earlier PR.ObjectType: Renderstypedefinitions with fields,@composeinterface implementations, and@operationFieldssupport.InterfaceType: Rendersinterfacedefinitions with fields.InputType: Rendersinputdefinitions with fields. Automatically appendsInputsuffix when a model appears in both input and output positions (checked viamodelVariantscontext).@composeinterface implementation, and Input suffix logic.Test plan
npm run buildsucceedsnpm test— 165 tests pass (148 prior + 17 new)