Skip to content

Conversation

@mohammedfirdouss
Copy link
Contributor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@eeshaanSA
Copy link
Contributor

Hey @mohammedfirdouss, left some comments, PTAL when you have time!

@eeshaanSA eeshaanSA self-requested a review January 7, 2026 07:18
@mohammedfirdouss
Copy link
Contributor Author

Hey @mohammedfirdouss, left some comments, PTAL when you have time!

Alright @eeshaanSA. No comments here, maybe the other PRs?


- **Plugins** run as gRPC servers, launched and managed by piped
- **Deploy targets** define where a plugin deploys (e.g., a Kubernetes cluster)
- Plugins can be **official** (maintained by PipeCD team) or **community-contributed**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more info here about official plugins (expanded info about how they are maintained) can be good to have, though not necessary. Current version looks good too! Please comment if you have any ideas.

Copy link
Contributor Author

@mohammedfirdouss mohammedfirdouss Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no problem @eeshaanSA, For now I have no ideas yet but i updated docs-dev/concepts with v1 content (was still showing old Platform Provider docs) and added links from the plugins guide to the Concepts page for readers who want more background on the architecture.

@eeshaanSA
Copy link
Contributor

@mohammedfirdouss, sorry, my bad. I had not finished the review yet. PTAL now, you should see them!

@mohammedfirdouss
Copy link
Contributor Author

@mohammedfirdouss, sorry, my bad. I had not finished the review yet. PTAL now, you should see them!

Yes I can. Thanks! @eeshaanSA

@eeshaanSA eeshaanSA added area/docs contribex Improve contributor experience labels Jan 7, 2026
Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mohammedfirdouss, PTAL when you have time! Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't look relevant to the PR. If this is about improving the texts in concepts section, it would be better to make a different PR for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can open another PR for that, i will go ahead to remove them now. Also, Should we add a version note indicating this applies to v1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs contribex Improve contributor experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants