Switch to OIDC Trusted Publishers#71
Merged
pipedrive-public-gha-bot[bot] merged 1 commit intoMay 22, 2026
Merged
Conversation
…to Node 24 Node 24 ships npm 11.x which is required for OIDC Trusted Publishers (npm 10.x in Node 22 does not support it). Adds permissions block and use_trusted_publisher flag to the publish workflow; supported_versions extended to [22,24]. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
siirimangus
reviewed
May 22, 2026
| contents: write | ||
| with: | ||
| revision: ${{ github.event.pull_request.head.ref }} | ||
| supported_versions: '[22]' |
Contributor
There was a problem hiding this comment.
In .nvmrc the Node version was set to 24. Is it correct that here it stays unchanged? Also, in package.json the version is still set to >=22 (yes, the 24 is covered :), but would it make sense to change it there as well?)
Contributor
Author
There was a problem hiding this comment.
With this setup, the publish workflow runs the tests with version 24 (main version based on the .nvmrc) and runs with version 22, which respects the package.json
siirimangus
approved these changes
May 22, 2026
evenluiv
approved these changes
May 22, 2026
pipedrive-public-gha-bot
Bot
deleted the
CICDL-258-oidc-trusted-publishers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch npm publishing from token-based auth to OIDC Trusted Publishers. Also upgrades .nvmrc to Node 24 (npm 11.x required for OIDC).
Changes
.github/workflows/cicd_npm-publish.yml: adduse_trusted_publisher: true,permissionsblock, extendsupported_versionsto[22,24].nvmrc: bump from 22 to 24Manual follow-up required
Generated with Claude Code