Skip to content

отчепятки и поправил ссылку при открытии доклада без митапа ( теперь без ошибки ) - #77

Open
Dev-cmyser wants to merge 11 commits into
piterjs:masterfrom
Dev-cmyser:post-genertor
Open

Conversation

@Dev-cmyser

Copy link
Copy Markdown

No description provided.

@Dev-cmyser
Dev-cmyser marked this pull request as draft April 6, 2026 14:35
@Dev-cmyser
Dev-cmyser marked this pull request as ready for review April 6, 2026 15:17
@Dev-cmyser Dev-cmyser changed the title отчепятки отчепятки и поправил ссылку при открытии доклада без митапа ( теперь без ошибки ) Apr 6, 2026
Comment thread app/app.view.ts
Comment thread app/app.view.ts Outdated
if( ids2 ) return ids2
const speech_id = this.speech_id()
if( speech_id ) {
const meetup = this.speech( speech_id as $mol_int62_string ).meetup()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему бы не перенести эту логику в meetup_current?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

попробовал сделать, некрасиво получается как то

Comment thread app/app.view.ts Outdated

@Dev-cmyser Dev-cmyser left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на ревью

Comment thread meetup/meetup.ts

@Dev-cmyser Dev-cmyser left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

жду ревью
попробовал исправить еще список гостей что бы не исчезал

Comment thread speaker/speaker.ts
return URL.createObjectURL( this.photo_blob() )

const blob = this.photo_blob()
if( !blob?.size ) return ''

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about:blank может? А то текущую страницу будет пытаться грузить.

Comment thread app/app.view.ts

const speech_id = this.speech_id()
if( speech_id ) {
const meetup = this.speech( speech_id as $mol_int62_string ).meetup()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется тут не хватает speech_current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants