network: add DetachedSignatureAvailableCheck#771
Open
parona-source wants to merge 1 commit intopkgcore:masterfrom
Open
network: add DetachedSignatureAvailableCheck#771parona-source wants to merge 1 commit intopkgcore:masterfrom
parona-source wants to merge 1 commit intopkgcore:masterfrom
Conversation
Signed-off-by: Alfred Wingate <parona@protonmail.com>
parona-source
force-pushed
the
detached-signature-check
branch
from
8697f61 to
694a268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thesamesam was interested in this
I couldn't fully follow precedent with the network tests. The check deals with multiple network requests in one go so just a mocking of the returnvalue wasn't enough.